Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix toggleterm & add config for diffview.nvim #913

Closed
wants to merge 2 commits into from
Closed

fix toggleterm & add config for diffview.nvim #913

wants to merge 2 commits into from

Conversation

YuCao16
Copy link
Contributor

@YuCao16 YuCao16 commented Jul 30, 2023

  1. toggleterm.nvim: fix toggleterm start_in_insert not working.
  2. diffview.nvim: disable lsp diagnostics in Diffview mode, otherwise, lsp goes crazy due to the conflict markers (<<<) and then crashes.

@ayamir
Copy link
Owner

ayamir commented Jul 31, 2023 •
edited
Loading

  1. Can't repro on my wsl.
  2. What you introduced is set in the default setup function as diffview.nvim's readme said.

@YuCao16
Copy link
Contributor Author

YuCao16 commented Jul 31, 2023

  1. Can't repro on my wsl.
  2. What you introduced is set in the default setup function as diffview.nvim's readme said.

  1. Are you using 0.10, because I'm gussing it's a nightly issue for autocmd.

  2. I ran into this problem yesterday and I thought it wasn't turned on by default, sorry about this. I will try to create a repro code and raise issue in diffview.

@ayamir
Copy link
Owner

ayamir commented Jul 31, 2023

No, I tested it for 0.9. You should open a pr for 0.10 branch instead of main.

@YuCao16
Copy link
Contributor Author

YuCao16 commented Jul 31, 2023

No, I tested it for 0.9. You should open a pr for 0.10 branch instead of main.

Sure, I will.

@YuCao16 YuCao16 closed this Jul 31, 2023
Jint-lzxy added a commit that referenced this pull request Aug 2, 2023
@Jint-lzxy
fix(toggleterm): start_in_insert not working
9aaedcb 
IMO this is a good patch (taken from #913) and should be merged

---
Co-authored-by: YuCao16 <[email protected]>
@Jint-lzxy Jint-lzxy mentioned this pull request Aug 2, 2023
Merged
ayamir pushed a commit that referenced this pull request Aug 2, 2023
@Jint-lzxy
fix(toggleterm): start_in_insert not working (#919)
f302bf4 
IMO this is a good patch (taken from #913) and should be merged

---
Co-authored-by: YuCao16 <[email protected]>
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Aug 2, 2023
@Jint-lzxy @singlemancombat
fix(toggleterm): start_in_insert not working (ayamir#919)
54daff5 
IMO this is a good patch (taken from ayamir#913) and should be merged

---
Co-authored-by: YuCao16 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuCao16 @ayamir