-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider): leave provider specifications to user #887
Conversation
the pr should done it's job (i just eyeballed it, not really applying the pr), but i wonder if their's a better approach to it. |
The workaround that crossed my mind is to allow users to define their custom Python provider(s) (which may include command-line options). But I'm not sure if this is feasible cause I rarely use Python-related stuffs |
At least in NxOS, it is difficult to know the exact configuration of the latest neovim from outside of nix, since the product is managed as a hash. |
I use python everyday but I use conda to manage envs so just respect Another approach is to respect the settings in |
The focus of the issue I was thinking about was about NixOS. |
So to summarize, is it feasible to directly use the exec |
It can be used if it contains the necessary libraries for python such as global or |
IMO in this case we can just leave it alone, cause if this option is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add(settings): dont_set_python_host_prog option * fix(provider): leave provider specifications to user * remove unused code --------- Co-authored-by: Jint-lzxy <[email protected]>
#886