-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(null-ls): specify rustfmt
manually
#852
Conversation
Thanks for the script! But the problem is we probably need to avoid installing multiple versions of Rust in parallel - so things become much more complex here, as Rust is distributed in multiple ways:
So if we decide to automate this process, the following should be considered:
|
aha, I didn't thought about those details, indeed this is important. |
IMO then we can just put a hint here, just like the Lines 399 to 402 in 656e48a
|
that would do too. upvote for this |
Done :D 98e0678
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(null-ls): specify `rustfmt` manually * feat(scripts): add notes regarding `rustup` * fixup! feat(scripts): add notes regarding `rustup`
Haven't introduced
rustup
into the install script(s) yet cause I can't figure out how to automate this process 😢