-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lsp): set lower pylsp severity #774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayamir
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Set it as info is ok for me.
It can be introduced in next pr to make diagnostics severity configurable for user. |
Merged
ayamir
added a commit
that referenced
this pull request
May 30, 2023
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
May 30, 2023
Jint-lzxy
added a commit
that referenced
this pull request
May 30, 2023
Jint-lzxy
added a commit
that referenced
this pull request
May 30, 2023
Jint-lzxy
added a commit
that referenced
this pull request
May 30, 2023
* feat: make severity_limit configurable(#774), add more notes for users. * fixup! feat: make severity_limit configurable(#774), add more notes for users. --------- Co-authored-by: Jint-lzxy <[email protected]>
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
May 30, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users. * fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users. --------- Co-authored-by: Jint-lzxy <[email protected]>
leavers
pushed a commit
to leavers/nvimdots
that referenced
this pull request
May 31, 2023
leavers
pushed a commit
to leavers/nvimdots
that referenced
this pull request
May 31, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users. * fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users. --------- Co-authored-by: Jint-lzxy <[email protected]>
csyJoy
pushed a commit
to csyJoy/nvimdots
that referenced
this pull request
Jun 4, 2023
csyJoy
pushed a commit
to csyJoy/nvimdots
that referenced
this pull request
Jun 4, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users. * fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users. --------- Co-authored-by: Jint-lzxy <[email protected]>
CharlesChiuGit
referenced
this pull request
in CharlesChiuGit/nvimdots.lua
Jun 19, 2023
bleedingfight
pushed a commit
to bleedingfight/nvimdots
that referenced
this pull request
Jun 22, 2023
bleedingfight
pushed a commit
to bleedingfight/nvimdots
that referenced
this pull request
Jun 22, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users. * fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users. --------- Co-authored-by: Jint-lzxy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-lsp/python-lsp-ruff#38
Not sure to use "Information" or "Hint", and maybe
settings["diagnostics_virtual_text"]
should be more controlable so one can define