Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lsp): set lower pylsp severity #774

Merged
merged 1 commit into from
May 30, 2023

Conversation

fecet
Copy link
Contributor

@fecet fecet commented May 30, 2023

python-lsp/python-lsp-ruff#38
Not sure to use "Information" or "Hint", and maybe settings["diagnostics_virtual_text"] should be more controlable so one can define

	vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with(vim.lsp.diagnostic.on_publish_diagnostics, {
		signs = true,
		underline = true,
		virtual_text = { require("core.settings").diagnostics_virtual_text, severity_limit = "Warning" },
		-- set update_in_insert to false bacause it was enabled by lspsaga
		update_in_insert = false,
	})

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Set it as info is ok for me.

@ayamir
Copy link
Owner

ayamir commented May 30, 2023

maybe settings["diagnostics_virtual_text"] should be more controlable so one can define

	vim.lsp.handlers["textDocument/publishDiagnostics"] = vim.lsp.with(vim.lsp.diagnostic.on_publish_diagnostics, {
		signs = true,
		underline = true,
		virtual_text = { require("core.settings").diagnostics_virtual_text, severity_limit = "Warning" },
		-- set update_in_insert to false bacause it was enabled by lspsaga
		update_in_insert = false,
	})

It can be introduced in next pr to make diagnostics severity configurable for user.

@ayamir ayamir merged commit e5208d6 into ayamir:main May 30, 2023
@ayamir ayamir mentioned this pull request May 30, 2023
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request May 30, 2023
Jint-lzxy added a commit that referenced this pull request May 30, 2023
* feat: make severity_limit configurable(#774), add more notes for users.

* fixup! feat: make severity_limit configurable(#774), add more notes for users.

---------

Co-authored-by: Jint-lzxy <[email protected]>
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request May 30, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users.

* fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users.

---------

Co-authored-by: Jint-lzxy <[email protected]>
leavers pushed a commit to leavers/nvimdots that referenced this pull request May 31, 2023
leavers pushed a commit to leavers/nvimdots that referenced this pull request May 31, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users.

* fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users.

---------

Co-authored-by: Jint-lzxy <[email protected]>
csyJoy pushed a commit to csyJoy/nvimdots that referenced this pull request Jun 4, 2023
csyJoy pushed a commit to csyJoy/nvimdots that referenced this pull request Jun 4, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users.

* fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users.

---------

Co-authored-by: Jint-lzxy <[email protected]>
CharlesChiuGit referenced this pull request in CharlesChiuGit/nvimdots.lua Jun 19, 2023
bleedingfight pushed a commit to bleedingfight/nvimdots that referenced this pull request Jun 22, 2023
bleedingfight pushed a commit to bleedingfight/nvimdots that referenced this pull request Jun 22, 2023
* feat: make severity_limit configurable(ayamir#774), add more notes for users.

* fixup! feat: make severity_limit configurable(ayamir#774), add more notes for users.

---------

Co-authored-by: Jint-lzxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants