-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load SessionLens
manually via user command
#745
Conversation
A more reasonable way is judge if setuped when execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am hesitant to merge this PR into main
b/c we have already set auto-session
to load-on-demand. Perhaps @Saafo can add this to his/her custom config 👍
A more reasonable way is judge if setuped
We have package.loaded
:)
Both are fine to me! |
Seems I can't set it like below because the setup status of session_lens have no direct relation of whether vim.api.nvim_create_user_command("SessionLenShow", function()
if not package.loaded("telescope") then
require("auto-session").setup_session_lens()
end
require("auto-session.session-lens").search_session()
end, { nargs = 0 }) |
We could check |
I tend to merge it into main for convenience and this solution is acceptable for users who use this plugin's functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted phrasing 👍
Co-authored-by: 冷酔閑吟 <[email protected]>
SessionLens
manually via user command
* feat: disable session_lens load_on_setup, create command for search_session. * perf: setup_session_lens only it not loaded. * perf: update command name and side note. --------- Co-authored-by: Jint-lzxy <[email protected]>
* feat: disable session_lens load_on_setup, create command for search_session. * perf: setup_session_lens only it not loaded. * perf: update command name and side note. --------- Co-authored-by: Jint-lzxy <[email protected]> (cherry picked from commit 351549c)
* feat: disable session_lens load_on_setup, create command for search_session. * perf: setup_session_lens only it not loaded. * perf: update command name and side note. --------- Co-authored-by: Jint-lzxy <[email protected]>
#742