Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nvim-treesitter): add nvim-treesitter-context #707

Merged
merged 1 commit into from
May 4, 2023
Merged

feat(nvim-treesitter): add nvim-treesitter-context #707

merged 1 commit into from
May 4, 2023

Conversation

Saafo
Copy link
Contributor

@Saafo Saafo commented May 4, 2023

@Saafo
feat(nvim-treesitter): add nvim-treesitter-context
fa5fb5c 
Change-Id: I7e06be70de44f1a9962187d6358810f9d7d27fdb
@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented May 4, 2023 •
edited
Loading

Don't we need to require it?
https://github.com/nvim-treesitter/nvim-treesitter-context#configuration

@CharlesChiuGit
Copy link
Collaborator

Also, this might need to set the highlightings in #699 as well.

@CharlesChiuGit CharlesChiuGit marked this pull request as draft May 4, 2023 08:57
@ayamir
Copy link
Owner

ayamir commented May 4, 2023

Don't we need to require it? https://github.com/nvim-treesitter/nvim-treesitter-context#configuration

no need

@Saafo
Copy link
Contributor Author

Saafo commented May 4, 2023 •
edited
Loading

Don't we need to require it? https://github.com/nvim-treesitter/nvim-treesitter-context#configuration

The default value is good enough to me, so we can just add to dependencies, not to require it.

Also, this might need to set the highlightings in #699 as well.

I've read this pr and I'm exciting to it! But I think it might out of this pr's scape since the highlighting pr is not merged yet 🤔.

@Saafo Saafo marked this pull request as ready for review May 4, 2023 09:06
@CharlesChiuGit
Copy link
Collaborator

I've read this pr and I'm exciting to it! But I think it might out of this pr's scape since the highlighting pr is not merged yet thinking.

make sense.

CharlesChiuGit
CharlesChiuGit reviewed May 4, 2023
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit f9cb8fe into ayamir:main May 4, 2023
@Saafo Saafo deleted the feat/ts-context branch May 4, 2023 13:37
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request May 10, 2023
@ayamir @boomker
Merge pull request ayamir#707 from Saafo/feat/ts-context
133ab67 
feat(nvim-treesitter): add nvim-treesitter-context

(cherry picked from commit f9cb8fe)
@Jint-lzxy Jint-lzxy mentioned this pull request Oct 12, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saafo @CharlesChiuGit @ayamir