Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lspsaga): support v0.2.9 #601

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

Jint-lzxy
Copy link
Collaborator

This commit added support for lspsaga v0.2.9. Changes include:

  • keymap for show_line_diagnostics was changed to <leader>ld (previously <leader>sl)
  • show_cursor_diagnostics is deprecated - <leader>sc is now unset
  • finder: option edit --> expand_or_jump
  • diagnostic:
    • new options: text_hl_follow, extend_relatedInformation, keys.*
  • hover: open_link, default to gl
  • outline: All options are merged to give expand_or_jump
  • ui:
    • removed entry: diagnostic
    • added entry: actionfix (ui.Spell)

This commit added support for lspsaga v0.2.9. Changes include:
* keymap for `show_line_diagnostics` was changed to `<leader>ld`
  (previously `<leader>sl`)
* `show_cursor_diagnostics` is deprecated - `<leader>sc` is now unset
* finder: option `edit` -> `expand_or_jump`
* diagnostic:
  * new options: `text_hl_follow`, `extend_relatedInformation`, `keys`
* hover: `open_link`, default to `gl`
* outline: All options are merged to give `expand_or_jump`
* ui:
  * removed entry: `diagnostic`
  * added entry: `actionfix` (`ui.Spell`)
@aarnphm
Copy link
Collaborator

aarnphm commented Mar 27, 2023

Why does lspsaga introduce breaking changes every release it feels like 😢

Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quickie

lua/modules/configs/completion/lspsaga.lua Outdated Show resolved Hide resolved
@Jint-lzxy Jint-lzxy force-pushed the feat/lspsaga-v0.2.9 branch from 7a029fe to e456ff4 Compare March 28, 2023 14:23
@Jint-lzxy
Copy link
Collaborator Author

e456ff4:

-- Set the command for handling external URLs here. The executable must be available on your $PATH.
-- This entry is IGNORED on Windows and macOS, which have their default handlers builtin.
---@type string
settings["external_browser"] = "chrome-cli open"

and

open_browser = "silent !" .. require("core.settings").external_browser,

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 2c246ae into ayamir:main Mar 29, 2023
@Jint-lzxy Jint-lzxy deleted the feat/lspsaga-v0.2.9 branch March 29, 2023 10:58
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request Apr 4, 2023
feat(lspsaga): support v0.2.9

(cherry picked from commit 2c246ae)
YanTree pushed a commit to YanTree/nvim that referenced this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants