fix(icons)!: update icon codepoints

[Jint-lzxy]

Fixes #439. This PR will be marked as ready for review when nerd font v3.0.0 is released - now Material Design Icons still have some display problems.

Searched using /[\uf500-\ufd46].

[Jint-lzxy]

This PR will be marked as ready for review when nerd font v3.0.0 is released.

@CharlesChiuGit It's a WIP in upstream repo.

[CharlesChiuGit]

Cool project. Maybe worth checking our font icons with this tool.
https://github.com/loichyan/nerdfix

[CharlesChiuGit]

it's finally here!

https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.0

[Jint-lzxy]

Now working on this 👍

[Jint-lzxy]

@CharlesChiuGit @ayamir So here's the deal: Given that some of the default icons used by upstream repos will (probably) be replaced with nf-cod-* (codeicons), shall we also update icons.lua to keep consistency with theirs?

Ref:
nvim-tree/nvim-web-devicons#264
onsails/lspkind.nvim#64

[CharlesChiuGit]

i'll look into that after i hot home

quick question: can cod icons displayed without installing codicons.ttf?

[Jint-lzxy]

quick question: can cod icons displayed without installing codicons.ttf?

Yes as they're part of the NF collection.

[ayamir]

@CharlesChiuGit @ayamir So here's the deal: Given that some of the default icons used by upstream repos will (probably) be replaced with nf-cod-* (codeicons), shall we also update icons.lua to keep consistency with theirs?

Ref: nvim-tree/nvim-web-devicons#264 onsails/lspkind.nvim#64

Agree on this

[Jint-lzxy]

c5da797 simply ran nerdfix without making any special adjustments:

find ./lua -type f -exec $TMPDIR/gh/unk1/bin/nerdfix fix --replace nf-mdi-,nf-md- {} \;

[CharlesChiuGit]

@CharlesChiuGit @ayamir So here's the deal: Given that some of the default icons used by upstream repos will (probably) be replaced with nf-cod-* (codeicons), shall we also update icons.lua to keep consistency with theirs?

Ref: nvim-tree/nvim-web-devicons#264 onsails/lspkind.nvim#64

Seems legit. agreed.

[Jint-lzxy]

Looks like upstream repos decided to use Material Design Icons. So this PR is good 👍 A new release (v3.0.0) will be published after merging to remind users to update their installed Nerd Fonts.

[Jint-lzxy]

[View draft release]

[AngelontheRoad]

New icons is weird after I replace the old icons.lua with icons.lua here. The font I use is the new nerd font JetBrainsMono Nerd Font

[Jint-lzxy]

@AngelontheRoad init.lua#diff. You have "icons with incorrect size". Quoting the release note:

• Starting from v3.0.0, please use the Mono variant (Nerd Font Mono or NFM) as your GUI font.

[AngelontheRoad]

@AngelontheRoad init.lua#diff. You have "icons with incorrect size". Quoting the release note:

• Starting from v3.0.0, please use the Mono variant (Nerd Font Mono or NFM) as your GUI font.

I tried some NFM font, but it not works.

[Jint-lzxy]

I tried some NFM font, but it not works.

In fact it is working, those undefined icons you observe is b/c nvim-tree/nvim-web-devicons#264 hasn't yet been merged. btw some Nerd Fonts have rendering issues when they're used in terminal emulators, you can use the Prompo * variant or another GUI font.

[AngelontheRoad]

I tried some NFM font, but it not works.

In fact it is working, those undefined icons you observe is b/c nvim-tree/nvim-web-devicons#264 hasn't yet been merged. btw some Nerd Fonts have rendering issues when they're used in terminal emulators, you can use the Prompo * variant or another GUI font.

Thanks for your reply! I'd like to use old nerd font until all preparations done.

[ayamir]

LGTM

[CharlesChiuGit]

sorry that i couldn't review this, my pc is down right now due to a transformer accident.

[Jint-lzxy]

sorry that i couldn't review this, my pc is down right now due to a transformer accident.

@CharlesChiuGit Sorry I just noticed that (#713 (comment)). No worries! 've crossed my fingers for you 🍻

[yyb196]

@Jint-lzxy how can I disable this material icon. in my using case, it just render like a mess.

mosh-client ---remote connect---> server(include mosh-server tmux nvim)

after update to recent version, some characters randomly left on screen as below picture shows. I need a way to disable this feature I think, help please.

[Jint-lzxy]

after update to recent version, some characters randomly left on screen as below picture shows

@yyb196 This should be a problem with your terminal - it probably failed to perform a full-screen redraw when Neovim requested it to do so. Can you reproduce this issue on another emulator?

[yyb196]

@Jint-lzxy thanks for your reponse.

yes, I can reproduce it on iterm2, alacritty and kitty, and on iOS devices I can reproduce it on blink.

If I change to use ssh instead of mosh it works on all above terminal emulator.

I know its a bug of mosh protocol, but I need to develop on my macbook or my ipad using mosh connect to remote server, If I use ssh the connection randomly close if I move or switch app on my ios.
mobile-shell/mosh#1041

Maybe we could find all the icons which using new codepoint and add a swtich to replace it with old codepoint?

[Jint-lzxy]

Maybe we could find all the icons which using new codepoint and add a swtich to replace it with old codepoint?

@yyb196 Sorry I didn't quite get ur point. If I read this right, those "observations" do share the same root cause - ur shell (or protocol) doesn't support certain escape sequences, but ur terminfo database reports that they're actually supported - that's why u get random characters (that are part of such escape sequences which are left unprocessed). What leads u to think that this is caused by codepoint changes?

[CharlesChiuGit]

agree with Jint, I dont think it's about the new codepoint.
if u think old codepoint should work, u can try releases before v3.0.0 and show us the results.
if it's about your terminal of choice, well, then u better switch another terminal. we can't help u with that.