Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge user customized config with predefined. #1376

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Dec 11, 2024

@ayamir
Copy link
Owner Author

ayamir commented Dec 11, 2024

@JoeMob

@ayamir
Copy link
Owner Author

ayamir commented Dec 12, 2024

This commit has some problems, I will fix it later today.

@ayamir
Copy link
Owner Author

ayamir commented Dec 12, 2024

This commit has some problems, I will fix it later today.

Done. @JoeMob @CharlesChiuGit

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 42ce15d into main Dec 12, 2024
4 checks passed
@ayamir ayamir deleted the fix/lsp-config branch December 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: user's lsp config replaced the whole config rather than merge predefined config with overwrite.
2 participants