Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eliminate warning in formatting.lua. #1180

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: eliminate warning in formatting.lua. #1180

merged 1 commit into from
Feb 22, 2024

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Feb 22, 2024

  1. adapt neovim new api to lsp clients.
  2. suppress the useless diagnostic warnings.
  3. introduce method variable for "textDocument/formatting".

@CharlesChiuGit
Copy link
Collaborator

https://neovim.io/doc/user/lsp.html#vim.lsp.get_clients()

CharlesChiuGit
CharlesChiuGit approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ayamir ayamir merged commit 258ef27 into main Feb 22, 2024
4 checks passed
@ayamir ayamir deleted the fix/diagnostics-in-formatting branch February 22, 2024 10:14
ayamir added a commit that referenced this pull request Feb 23, 2024
@ayamir
Revert "fix: eliminate warning in formatting.lua. (#1180)"
b8bed93 
This reverts commit 258ef27.
misumisumi pushed a commit to misumisumi/nvimdots that referenced this pull request Mar 5, 2024
@ayamir @misumisumi
fix: eliminate warning in formatting.lua. (ayamir#1180)
af2109b 
Signed-off-by: ayamir <[email protected]>
misumisumi pushed a commit to misumisumi/nvimdots that referenced this pull request Mar 5, 2024
@ayamir @misumisumi
Revert "fix: eliminate warning in formatting.lua. (ayamir#1180)"
7b14c8e 
This reverts commit 258ef27.
@TonyWu20 TonyWu20 mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayamir @CharlesChiuGit