Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keymap): use <C-w> with hjkl to navigate under t mode. #1029

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Oct 19, 2023

As discussed in #970, the keymaps of <C-h>, <C-j>, <C-k>, and <C-l> are usually defined as shell keymaps to do other things. For example, <C-l> is used to clear terminal output, which is used frequently. Old mappings just considered the consistency with those under normal mode and didn't consider the conflicts. IMO it should be fixed by ourselves instead of leaving it to users.
cc @Jint-lzxy @CharlesChiuGit

@ayamir ayamir linked an issue Oct 19, 2023 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, LGTM

@Jint-lzxy Jint-lzxy merged commit a0f8602 into main Oct 20, 2023
4 checks passed
@Jint-lzxy Jint-lzxy deleted the fix/keymap-in-term branch October 20, 2023 14:41
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C-k <bs> not work in terminal windows
3 participants