feat: support formatting changed lines only #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayamir <[email protected]>
|
@jh244212647 checkout to this pr and test it. |
|
测了一下，能满足需求，大佬非常给力，另外这个pr如果合入，settings["format_modify"] = false会不会好一点 |
Jint-lzxy
changed the title
aarnphm
approved these changes
Oct 18, 2023
Not all, just some support it: |
ttbug
pushed a commit
to ttbug/nvimconf
that referenced
this pull request
Oct 19, 2023
* feat: support format only for modidications. Signed-off-by: ayamir <[email protected]> * fixup:! correct the format logic. * fixup!: set `format_modify` = `false` by default. * fix: clarify `format_modify` & cleanup * fix: add missing `vim.notify` * fix CI * fix(settings): sort formatting-related entries --------- Signed-off-by: ayamir <[email protected]> Co-authored-by: Jint-lzxy <[email protected]>
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Oct 22, 2023
* feat: support format only for modidications. Signed-off-by: ayamir <[email protected]> * fixup:! correct the format logic. * fixup!: set `format_modify` = `false` by default. * fix: clarify `format_modify` & cleanup * fix: add missing `vim.notify` * fix CI * fix(settings): sort formatting-related entries --------- Signed-off-by: ayamir <[email protected]> Co-authored-by: Jint-lzxy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose it because this requirement is common as the readme of this plugin: https://github.com/joechrisellis/lsp-format-modifications.nvim#what-problem-does-this-solve
Additionally, it's inevitable to add this function by modifying the
formatting.luafile, which isn't what we want to see.