Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(telescope-frecency)!: remove support for sqlite.lua #1019

Merged
merged 2 commits into from
Oct 14, 2023
Merged

refactor(telescope-frecency)!: remove support for sqlite.lua #1019

merged 2 commits into from
Oct 14, 2023

Conversation

CharlesChiuGit
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit changed the title migrate(tele-frecency): remove sqlite.lua dependency migrate(telescope-frecency): remove sqlite.lua dependency Oct 11, 2023
@Jint-lzxy Jint-lzxy changed the title migrate(telescope-frecency): remove sqlite.lua dependency refactor(telescope-frecency)!: remove support for sqlite.lua Oct 12, 2023
@Jint-lzxy Jint-lzxy marked this pull request as ready for review October 12, 2023 13:14
Jint-lzxy
Jint-lzxy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, except for the NixOS part (I can’t test this right away).

p.s. We might also need to remove the "sqlite"-related section(s) from the wiki :D

@CharlesChiuGit
Copy link
Collaborator Author

@misumisumi would u might share some of your wisdom? lol

@misumisumi
Copy link
Collaborator

When I updated it and used it, it seems to be working without any problems.
We need to check whether sqlite is required to migrate from sqlite.lua.
If it is not necessary, I delete the corresponding nix code.
It's already late today, so I'll work on it tomorrow.

@misumisumi
Copy link
Collaborator

I checked and it works fine without sqlite.
Since the necessary work on NixOS has already been completed with @Jint-lzxy 's 9cb82d5, we can merge them.

@Jint-lzxy Jint-lzxy requested a review from ayamir October 14, 2023 03:25
CharlesChiuGit
CharlesChiuGit commented Oct 14, 2023
View reviewed changes
Copy link
Collaborator Author

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 861f6a5 into main Oct 14, 2023
4 checks passed
@ayamir ayamir deleted the from-migrate/telescope-frecency-remove-sqlite branch October 14, 2023 12:58
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Oct 19, 2023
@CharlesChiuGit @Jint-lzxy
refactor(telescope-frecency)!: remove support for sqlite.lua (ayami…
9d4e0e6 
…r#1019)

* migrate(tele-frecency): remove `sqlite.lua` dependency

Signed-off-by: Charles Chiu <[email protected]>

* chore: completely remove everything w/ sqlite.lua

---------

Signed-off-by: Charles Chiu <[email protected]>
Co-authored-by: Jint-lzxy <[email protected]>
This was referenced Oct 21, 2023
Merged
Merged
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Apr 5, 2024
@CharlesChiuGit @Jint-lzxy
refactor(telescope-frecency)!: remove support for sqlite.lua (ayami…
023e741 
…r#1019)

* migrate(tele-frecency): remove `sqlite.lua` dependency

Signed-off-by: Charles Chiu <[email protected]>

* chore: completely remove everything w/ sqlite.lua

---------

Signed-off-by: Charles Chiu <[email protected]>
Co-authored-by: Jint-lzxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayamir ayamir ayamir approved these changes

@Jint-lzxy Jint-lzxy Jint-lzxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlesChiuGit @misumisumi @Jint-lzxy @ayamir