Update package Cysharp.ZString to v2.5.1 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
===================================
Coverage 96% 96%
===================================
Files 91 91
Lines 3227 3227
===================================
Hits 3111 3111
Misses 116 116 ☔ View full report in Codecov by Sentry. |
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Jan 29, 2024
* Regression caused by axuno#368 * Stop namespace collision with Cysharp.Text nuget package * Affects: class, struct, interface, delegate, enum * using https://github.com/zzzprojects/findandreplace on command line, so we can automate this step: "fnr.exe" --cl --dir "SmartFormat.ZString\repo\src\ZString" --fileMask "*.cs,*.tt" --includeSubDirectories --caseSensitive --useRegEx --find "public (?=.*(class |struct |enum |interface |delegate ))" --replace "internal "
axunonb
added a commit
that referenced
this pull request
Jan 29, 2024
* Change all public types in namespace Cysharp.Text to internal * Regression caused by #368 * Stop namespace collision with Cysharp.Text nuget package * Affects: class, struct, interface, delegate, enum * using https://github.com/zzzprojects/findandreplace on command line, so we can automate this step: "fnr.exe" --cl --dir "SmartFormat.ZString\repo\src\ZString" --fileMask "*.cs,*.tt" --includeSubDirectories --caseSensitive --useRegEx --find "public (?=.*(class |struct |enum |interface |delegate ))" --replace "internal " * Add a unit test to get an alert when Cysharp.Text objects are public * Bump version to v3.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.