Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #345 #346

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Resolves #345 #346

merged 4 commits into from
Aug 3, 2023

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Aug 2, 2023

Changes:

  • PluralLocalizationFormatter does not treat numeric string as valid argument (i.e. estore behavior of v3.1.0 and before)
  • Bump version to v3.2.2
  • Update appveyor and github workflow CI

* PluralLocalizationFormatter does treat numeric string as valid argument
* Restore behavior of v3.1.0 and before
* Bump version to v3.2.2
* Update appveyor and github workflow CI
@axuno axuno deleted a comment from codecov bot Aug 2, 2023
@axunonb
Copy link
Member Author

axunonb commented Aug 2, 2023

@karljj1 Would you pls have a look?
See SonarCloud checks here: https://sonarcloud.io/summary/new_code?id=axunonb_SmartFormat&branch=pr%2Fplural-fmt-string-arg
And I'd be more than happy if you joined the project as a co-maintainer if your time allows

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100% and no project coverage change.

Comparison is base (c8a99c0) 96% compared to head (36680c3) 96%.

❗ Current head 36680c3 differs from pull request most recent head 32f5211. Consider uploading reports for the commit 32f5211 to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #346   +/-   ##
===================================
- Coverage    96%    96%   -0%     
===================================
  Files        91     91           
  Lines      3191   3190    -1     
===================================
- Hits       3077   3076    -1     
  Misses      114    114           
Files Changed Coverage Δ
...rtFormat/Extensions/PluralLocalizationFormatter.cs 92% <100%> (-<1%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

karljj1
karljj1 previously approved these changes Aug 3, 2023
src/SmartFormat/Extensions/PluralLocalizationFormatter.cs Outdated Show resolved Hide resolved
@karljj1
Copy link
Collaborator

karljj1 commented Aug 3, 2023

I'd be happy to help maintain. I probably won't be able to do much development but I'm happy to review pull requests and help out when I can.

@axunonb axunonb merged commit e98917a into axuno:main Aug 3, 2023
3 checks passed
@axunonb axunonb deleted the pr/plural-fmt-string-arg branch August 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants