Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Auto-detection of PluralLocalizationFormatter does not throw for values not convertible to decimal #330

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Fix: Auto-detection of PluralLocalizationFormatter does not throw for values not convertible to decimal #330

merged 2 commits into from
Feb 19, 2023

Commits on Feb 19, 2023

  1. Resolves axuno#329 

    Current behavior, introduced in v3.2.0:
When PluralLocalizationFormatter.CanAutoDetect == true, values not convertible to decimal will throw then trying to IConvertible.ToDecimal(...)

New behavior:
When PluralLocalizationFormatter.CanAutoDetect == true, for values not convertible to decimal, IFormatter.TryEvaluateFormat(...) will return false
    @axunonb
    axunonb committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6cbf7b1 View commit details
    Browse the repository at this point in the history

  2. Make PluralLocalizationFormatter.TryGetDecimalValue static

    @axunonb
    axunonb committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    49a3622 View commit details
    Browse the repository at this point in the history