Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChooseFormatter: case-sensitivity for option strings #253

Merged

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Mar 1, 2022

ChooseFormatter

Modified ChooseFormatter case-sensitivity for option strings. This modification is compatible with v2.

  • bool and null as string: always case-insensitive
  • using SmartSettings.CaseSensitivity unless overridden with ChooseFormatter.CaseSensitivity
  • option strings comparison is culture-aware (using CultureInfo arg to Smart.Format(...) or CurrentUICulture

* bool and null: always case-insensitive
* using SmartSettings.CaseSensitivity unless overridden with ChooseFormatter.CaseSensitivity
* option strings comparison is culture-aware
@axunonb axunonb merged commit c614eea into axuno:version/v3.0 Mar 1, 2022
@axunonb axunonb deleted the pr-choose-fmt-options-case-sensitivity branch March 1, 2022 23:07
@axunonb axunonb changed the title Pr choose fmt options case sensitivity PR ChooseFormatter: case-sensitivity for option strings Mar 2, 2022
@axunonb axunonb changed the title PR ChooseFormatter: case-sensitivity for option strings ChooseFormatter: case-sensitivity for option strings Mar 2, 2022
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
Modified ChooseFormatter case-sensitivity for option strings

* bool and null: always case-insensitive
* using SmartSettings.CaseSensitivity unless overridden with ChooseFormatter.CaseSensitivity
* option strings comparison is culture-aware, using CultureInfo if supplied in Smart.Format(...) or CurrentUICulture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant