Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend NullFormatter capabilities #199

Merged

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Sep 7, 2021

  • Behavior is comparable to ChooseFormatter
  • Allows for nested formats
  • More plausibility tests

axunonb and others added 30 commits April 17, 2021 10:25
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #199 (09c092e) into version/v3.0 (3188ed9) will increase coverage by 0%.
The diff coverage is 91%.

❗ Current head 09c092e differs from pull request most recent head c7484a4. Consider uploading reports for the commit c7484a4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           version/v3.0    #199   +/-   ##
============================================
  Coverage            16%     16%           
============================================
  Files                95      95           
  Lines             12770   12785   +15     
============================================
+ Hits               2083    2096   +13     
- Misses            10687   10689    +2     
Impacted Files Coverage Δ
src/SmartFormat/Extensions/NullFormatter.cs 92% <91%> (-8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3188ed9...c7484a4. Read the comment docs.

@axunonb axunonb merged commit e7724e8 into axuno:version/v3.0 Sep 7, 2021
@axunonb axunonb deleted the extend-null-formatter-capabilities branch September 7, 2021 21:30
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
NullFormatter processes complex formats:
* Behavior is comparable to ChooseFormatter
* Allows for nested formats
* More plausibility checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant