Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartsettings initialization in unit tests #190

Merged

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Aug 27, 2021

All SmartSettings properties are set when creating the SmartSettings instance.
Only effecting unit tests and demos.

axunonb and others added 30 commits April 17, 2021 10:25
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #190 (523f400) into version/v3.0 (dab5c1e) will increase coverage by 0%.
The diff coverage is 67%.

❗ Current head 523f400 differs from pull request most recent head f71ff67. Consider uploading reports for the commit f71ff67 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           version/v3.0   #190   +/-   ##
===========================================
  Coverage            95%    95%           
===========================================
  Files                50     50           
  Lines              2050   2049    -1     
===========================================
  Hits               1939   1939           
+ Misses              111    110    -1     
Impacted Files Coverage Δ
src/SmartFormat/Core/Parsing/Parser.cs 93% <0%> (+<1%) ⬆️
src/SmartFormat/Core/Settings/FormatterSettings.cs 100% <ø> (ø)
src/SmartFormat/Core/Settings/ParserSettings.cs 100% <ø> (ø)
src/SmartFormat/Smart.cs 100% <ø> (ø)
src/SmartFormat/SmartExtensions.cs 100% <ø> (ø)
src/SmartFormat/SmartFormatter.cs 96% <ø> (ø)
src/SmartFormat/Core/Settings/SmartSettings.cs 62% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab5c1e...f71ff67. Read the comment docs.

@axunonb axunonb merged commit 0d6f514 into axuno:version/v3.0 Aug 27, 2021
@axunonb axunonb deleted the smartsettings-initialization-unit-tests branch August 27, 2021 19:36
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
Assign all SmartSettings properties in unit tests when creating the instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant