Reduce substring allocations #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Alignment operator inheritance is optimized * DictionarySource performance improved
Codecov Report
@@ Coverage Diff @@
## version/v3.0 #189 +/- ##
===========================================
- Coverage 95% 95% -0%
===========================================
Files 49 50 +1
Lines 2019 2050 +31
===========================================
+ Hits 1910 1939 +29
- Misses 109 111 +2
Continue to review full report at Codecov.
|
axunonb
added a commit
that referenced
this pull request
Aug 27, 2021
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Mar 10, 2022
#### Target frameworks * Changed `netstandard2.0` to `netstandard2.1`. * `net461` support unchanged. * Added package `System.Memory` #### Remove repetitive substring allocations Connected modifications: * Added method `Write(ReadOnlySpan<char> text)` to `IFormattingInfo` * Generated substrings are cached in classes `Format`, `FormatItem`, `LiteralText`, `Placeholder` and `Selector`. * Evaluating escaped characters for `Placeholder.FormatterOptions` and `LiteralText` work without heap memory allocation. #### Alignment operator inheritance is optimized * Alignment implementation introduced with PR [axuno#174](axuno#174) is modified for better performance * Added method `Placeholder.AddSelector` * `Placeholder.Selectors` is now internal. Selectors are accessible with `IReadOnlyList<Selector> Placeholder.GetSelectors()`. #### DictionarySource performance improved * Implemented suggestion in issue [axuno#186](axuno#186) for better speed and less GC pressure. * Side effect: We're using the `CaseSensitivityType` of the dictionary for getting the value for a key. `Settings.GetCaseSensitivityComparison()` will not be applied.
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target frameworks
netstandard2.0tonetstandard2.1.net461support unchanged.System.MemoryRemove repetitive substring allocations
Connected modifications:
Write(ReadOnlySpan<char> text)toIFormattingInfoFormat,FormatItem,LiteralText,PlaceholderandSelector.Placeholder.FormatterOptionsandLiteralTextwork without heap memory allocation.Alignment operator inheritance is optimized
Placeholder.AddSelectorPlaceholder.Selectorsis now internal. Selectors are accessible withIReadOnlyList<Selector> Placeholder.GetSelectors().DictionarySource performance improved
CaseSensitivityTypeof the dictionary for getting the value for a key.Settings.GetCaseSensitivityComparison()will not be applied.