Parser has no string allocation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## version/v3.0 #187 +/- ##
===========================================
- Coverage 95% 95% -0%
===========================================
Files 49 49
Lines 2010 2019 +9
===========================================
+ Hits 1909 1910 +1
- Misses 101 109 +8
Continue to review full report at Codecov.
|
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Mar 10, 2022
Parser does not allocate any strings * Reducing GC pressure by avoiding temporary string assignments. Depending on the input string, GC is reduced by 50-80%. * ParserSettings: All internal character lists are returned as List<char>. * Internal character lists are cached in the parser for better performance * Connected modifications * New performance tests for Parser * Placeholder property Placeholder?.Parent is renamed to Placeholder?ParentPlaceholder to avoid confusion with Format property Format?.Parent. * Placeholder has additional internal properties FormatterNameStartindex, FormatterNameLength, FormatterOptionsStartindex and FormatterOptionsLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List<char>.ParserPlaceholderpropertyPlaceholder?.Parentis renamed toPlaceholder?ParentPlaceholderto avoid confusion withFormatpropertyFormat?.Parent.Placeholderhas additional internal propertiesFormatterNameStartindex,FormatterNameLength,FormatterOptionsStartindexandFormatterOptionsLength