-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection cache #155
Reflection cache #155
Conversation
Update to latest changes
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
===================================
Coverage 94% 94%
===================================
Files 42 42
Lines 1749 1762 +13
===================================
+ Hits 1651 1664 +13
Misses 98 98
Continue to review full report at Codecov.
|
Thanks, nice PR, will review this week. |
Did you measure the performance gain with the type cache? |
Really great PR, thanks! |
* Added reflection cache * Update for instance/class variables Co-authored-by: axunonb <[email protected]> Co-authored-by: Karl Jones <[email protected]>
* Added reflection cache * Update for instance/class variables Co-authored-by: axunonb <[email protected]>
Calling
GetMembers
is slow and generates a lot of garbage. This introduces a simple cache so that we only need to do the query once and then any subsequent queries can come from the cache. Its quite simple but gave a nice performance improvement and reduced the garbage by quite a lot for us :)