Add support for DNX/.NET Core

[glen-84]

No description provided.

[SeriousM]

you're invited to contribute.

btw, a one-liner, even it's a good idea, is kind of unpleasant. we're providing this great piece of software for free; treat it with love.

[glen-84]

I apologize, I didn't think that a description was necessary. I will check what needs to be done in order to support DNX and .NET core.

[SeriousM]

That would be great, thank you!
Am 08.06.2015 17:13 schrieb "Glen" [email protected]:

I apologize, I didn't think that a description was necessary. I will check
what needs to be done in order to support DNX and .NET core.

—
Reply to this email directly or view it on GitHub
#59 (comment)
.

[glen-84]

I really don't know how to retrofit this and maintain the existing project and solution files.

The best I could do is to implement this on another branch, without all the old project/solution files, etc.

[SeriousM]

I don't know what's the benefit of supporting DNX and what do you mean with .NET Core.
Could you just introduce us to the wished changes so that we can understand it without starting with the research from scratch?
Thanks

[glen-84]

.NET Core & DNX.

I'm going to try to implement this on a clean branch.

[glen-84]

https://github.com/glen-84/SmartFormat.NET/tree/DNX

It's building for dnx451 (regular framework under DNX), but there are 13 errors for DNX Core (~7 unique). You'll need to go through the list and find out if there are plans to add support for certain types/methods in .NET Core, and if not, find alternatives (assuming that you do want to support .NET Core).

Removed:

1. "releases" -- this is not something that's usually stored inside a source repo.
2. SmartFormat.Demo -- not sure if it's possible to run a WinForms app with DNX.
3. Extra solution files, NuGet stuff, etc. -- some things can be added back if necessary.

Notes:

1. NUnit does not yet support .NET Core (issue). You can either wait or switch to something like xUnit.

[SeriousM]

@glen-84, when do you expect that this is supported by SmartFormat.NET? Is it something you really wait for it or do you just want to support the project?

NUnit does not yet support .NET Core (issue). You can either wait or switch to something like xUnit.

I guess we will wait :)

[glen-84]

I was writing an implementation of an IStringLocalizer for ASP.NET 5 that allows the developer to use a custom string provider and string formatter, and I was going to use SmartFormat.NET and MessageFormat.NET as examples for the formatter.

i.e. It's not super-high priority.

[ghost]

Any updates on this? Microsoft just released the next version of Visual Studio with .NET CORE and we would like to migrate our software to the new .NET version.

[axunonb]

Created a Pull Request for supporting .NET Core (Standard 1.6). Finally supporting Async in both: .Net Framwork 2-4, but also .NET Core.
Any comments or discussion welcome.

[axunonb]

@scottrippey, @SeriousM: Priorities and interest in projects change, that's absolutely fine for me. Since MailMergeLib relies on SmartFormat.Net I would just like to know, whether there will be further development of this GitHub repository, or whether I'm on my own.

[scottrippey]

@axunonb Norbert, sorry for the delayed responses. As you've correctly guessed, I'm unable to continue development of this repo, as I've been out of .NET development for many years.
I'd be happy to add you as a collaborator, if you're interested. I'm not sure how NuGet publishing works, but I'd be willing to share my keys or transfer ownership, whatever's necessary!
Sorry about the lack of activity, I'm glad you found this package useful!

[axunonb]

@scottrippey Scott, I'm sorry to hear that, and I also think it would be a pity to stop working on SmartFormat.Net. So yes, you may add me as a collaborator and I'll try my best. With NuGet publishing I'll have to find out what to do. I'll let you know. For now thanks again for the good work with this repo.

[axunonb]

@scottrippey Scott, I had just been checking various options on how to go on with SmartFormat.Net. So:

• GitHub: A repository transfer to GitHub account axuno could be the most simple thing. But this is depending on your preferences.
• NuGet: Here I understand you could add Nuget account axuno as a package owner as described here.

[SeriousM]

Adding you as a collaborator is the most simple thing because the URL stays
the same.

[scottrippey]

@axunonb I've added you as both a GitHub contributor and a Nuget Owner! With great power comes great responsibility! :)
Thanks in advance for your help!

[axunonb]

Okay I confirmed both, thanks. @SeriousM are you still actively contributing? I'd be interested in your opinion about this Pull Request.
I also confirmed these issues which would be nice to "disappear".

[axunonb]

Pull request merged.

[SeriousM]

Hi Norbert, I'm not an active contributor anymore.
Sorry Scott, but my life is pretty demanding.
Cheers!

Am 01.11.2016 10:17 schrieb "Norbert Bietsch" [email protected]:

Closed #59 #59.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#59 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcMvVb8AQROgTVjaIQvYikHhNNKcaMCks5q5wONgaJpZM4E7uMC
.