-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default ErrorAction behavior to ThrowError #51
Comments
I think that |
Hi Scott! I've do some details into closed issue #50 Think the problem in SmartFormat still is |
ThrowError. Release mode and Debug shouldn't have different behaviors except logging level and performance. |
@mikasoukhov That's a really good recommendation. I agree, there shouldn't be a difference, My original justification was that I wanted Release mode to be very forgiving. However, now that it's on NuGet in Release mode, people are debugging with it in Release mode, which is a bad experience. |
Formatter and Parser have ErrorAction = ErrorAction.Ignore in debug and release configuration now: |
…replaceat Add ReplaceAt method to Utf16ValueStringBuilder
In "Release" mode, the default
ErrorAction
isIgnore
.This often results in a lot of confusion, especially since NuGet delivers the Release build.
So, a better default
ErrorAction
should be chosen.Choices are
Ignore
,ThrowError
,MaintainTokens
, orOutputErrorInResult
.In "Debug" mode, the default
ErrorAction
isThrowError
, which is appropriate.The text was updated successfully, but these errors were encountered: