-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional TFM to eliminate explicit dependency #380
Comments
Agree, NET60 is LTS and should become a target framework. Any reason not mentioning NET80 which is also LTS? Or newer NET80 instead of NET60? |
My preference is to target older frameworks ie net 6 so that more projects can benefit & only add the latest TFM where there is a benefit ie new language features or additional libraries bundled into the framework. |
Targeting
@karljj1 @thompson-tomo Appreciate your thoughts about the best way to go. |
My thoughts would be to switch to 2.6.0 nuget rather than the fork to improve maintaince going forward. If I am not mistaken you should be able to consume a net standard 2.0 library in net framework 4.6.1 hence I think we might be ok. If it doesn't then we should evaluate bumping the major so net framework can be dropped &/or conditional compilation. Could we conditional just the nuget hence maintenance should be more manageable. |
Yes, taking |
I also wouldn't consider it a breaking |
* Reference to Cysharp ZString v2.6.0 package (#382) * Reference Cysharp `ZString` v2.6.0 in `SmartFormat` project (net461 target use the netstandard2.0 assemblies) * Remove project `SmartFormat.Zstring` * Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString * Rename ZStringBuilderExtensions to ZStringBuilderUtilities * Exclude ZString wrappers from code coverage (#384) * Flag `ZStringBuilder` and `ZStringWriter`with `[ExcludeFromCodeCoverage]` * Add AltCoverAttributeFilter="ExcludeFromCodeCoverage" in CI tests * #380 Add net60 as additional target framework (#381) * #380 Add net 6 to STJ project and make other dependencies conditional * Optimize package properties. * Fix nullability and warning issues for Demo and Performance projects * chore: net60/ZString related housekeeping (#385) * Directory.Build.props: Remove duplicate entries from Demo and Performance projects * Enable NRT for Demo and Performance projects * Remove folder SmartFormat.ZString from former projects SmartFormat.ZString * Remove obsolete entries from SmartFormat.sln * Remove reference to former SmartFormat.ZString.dll from SmartFormat.csproj * Enable net60 for project SmartFormat (#387) * feat: Add net8.0 as a target framework (#388) * Mark CTOR overload (System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) as obsolete (like it is in net8.0). * Update proprocessor directives and nuget packages * Change appveyor_build_worker_image to Ubuntu2204 * Add net8.0 as target framework * Update target framework net461 to net462 * Bump version to v3.4.0 --------- Co-authored-by: James Thompson <[email protected]>
Resolved with #389 |
Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible
Describe the solution you'd like
I want the package to have an additional TFM (net 6) added so that the explicit dependency on System.Text.Json can be removed.
Describe alternatives you've considered
Accept the additional dependency
Additional context
n/a
The text was updated successfully, but these errors were encountered: