Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mempool)!: check gas limit range #1634

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(mempool)!: check gas limit range #1634

merged 2 commits into from
Dec 13, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 13, 2023 •
edited
Loading

What this PR does / why we need it?

This PR make the check gas limit process in mempool same as API.

What is the impact of this PR?

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from a team as a code owner December 13, 2023 02:33
@KaoImin KaoImin changed the title fix(mempool): check gas limit range fix(mempool)!: check gas limit range Dec 13, 2023
@KaoImin KaoImin requested review from Flouse and driftluo and removed request for wenyuanhust December 13, 2023 02:40
@Flouse Flouse linked an issue Dec 13, 2023 that may be closed by this pull request
bug: bypass restrictions through p2p message, even cause panic #1586
Closed
3 tasks
@KaoImin KaoImin added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 68a7b4a Dec 13, 2023
23 checks passed
@KaoImin KaoImin deleted the fix-mempool-check-gas branch December 13, 2023 07:21
Flouse added a commit that referenced this pull request Dec 13, 2023
@Flouse
Backport #1634 #1621 to 0.3.x-dev
0baa699
Flouse added a commit that referenced this pull request Dec 13, 2023
@Flouse
docs: add #1621 and #1634 into CHANGELOG
588c276
Flouse added a commit that referenced this pull request Dec 18, 2023
@Flouse
docs: add #1621 and #1634 into CHANGELOG
4e88781
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2023
@Flouse
chore: bump Axon version to 0.3.0-beta (#1627)
983f023 
* chore: bump axon version to 0.3.0-beta

* chore(docker): build ghcr image for alpha branch

* docs: add #1621 and #1634 into CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunchengzhu sunchengzhu sunchengzhu approved these changes

@driftluo driftluo driftluo approved these changes

@Flouse Flouse Flouse approved these changes

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: bypass restrictions through p2p message, even cause panic
4 participants
@KaoImin @Flouse @driftluo @sunchengzhu