Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change estimate gas calculation #1626

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 7, 2023

What this PR does / why we need it?

This PR disable the estimate flag of EVM config when estimate gas. The estimate gas returns 1.25 * gas_used as result.

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from a team as a code owner December 7, 2023 05:28
@KaoImin
Copy link
Contributor Author

KaoImin commented Dec 7, 2023

/run-ci

Copy link

github-actions bot commented Dec 7, 2023

CI tests run on commit:

CI test list:

  • openzeppelin_test_6_10.yml
  • openzeppelin_test_11.yml
  • openzeppelin_test_16_19.yml
  • openzeppelin_test_1_5_and_12_15.yml
  • v3_core_test.yml
  • web3_compatible.yml

Please check ci test results later.

@KaoImin KaoImin requested review from Flouse and yangby-cryptape and removed request for wenyuanhust December 7, 2023 06:13
@KaoImin KaoImin requested review from Flouse, sunchengzhu and a team December 7, 2023 06:29
@Flouse Flouse added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit d38ae58 Dec 7, 2023
20 checks passed
@KaoImin KaoImin deleted the refactor-estimate-gas branch December 7, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants