refactor!: call reserved system contract address is forbidden #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sunchengzhu
approved these changes
Nov 28, 2023
Flouse
reviewed
Nov 28, 2023
driftluo
approved these changes
Nov 28, 2023
KaoImin
force-pushed
the
fix-dispatch-system-contract
branch
from
238600e to
0fe15ac
Compare
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR change the call system contract address process. Call a reserved system contract address is forbidden during
eth_calleth_estimateGasWhat is the impact of this PR?
PR relation:
callmethod in executor should handle system contracts asexecmethod does. #1592CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description