Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support stop at specific height #1581

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat: support stop at specific height #1581

merged 2 commits into from
Nov 21, 2023

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented Nov 21, 2023 •
edited
Loading

What this PR does / why we need it?

Close #1306

What is the impact of this PR?

No Breaking Change

Add two options on the run command:

  • --mine-blocks specific how many blocks to mine before exit
  • --mine-to-height specific a block height, axon will exit after mined the block

Example:

# mine 3 blocks, then exit
target/debug/axon run --config devtools/chain/config.toml --mine-blocks 3

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@jjyr jjyr requested a review from yangby-cryptape November 21, 2023 07:50
@jjyr jjyr requested a review from a team as a code owner November 21, 2023 07:50
@jjyr jjyr requested a review from blckngm November 21, 2023 07:50
@Flouse Flouse added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit f692b86 Nov 21, 2023
21 checks passed
@Flouse Flouse mentioned this pull request Nov 24, 2023
Open
@KaoImin KaoImin deleted the feat-exit-after-sync-n-blocks branch November 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunchengzhu sunchengzhu sunchengzhu approved these changes

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@KaoImin KaoImin KaoImin approved these changes

@Flouse Flouse Flouse approved these changes

@blckngm blckngm Awaiting requested review from blckngm blckngm is a code owner automatically assigned from axonweb3/axon-dev

@Simon-Tl Simon-Tl Awaiting requested review from Simon-Tl

Assignees
No one assigned
Labels
feature skip_changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop chain after a specified number of blocks mined or reach a specified height.
5 participants
@jjyr @Flouse @KaoImin @yangby-cryptape @sunchengzhu