-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: fix the implementation of Axon Tries #1580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
add-hash-for-trie-tree-keys
branch
6 times, most recently
from
November 23, 2023 08:27
f2d881e
to
47a49ca
Compare
driftluo
requested review from
blckngm,
wenyuanhust and
KaoImin
and removed request for
wenyuanhust
November 23, 2023 08:57
blckngm
reviewed
Nov 23, 2023
blckngm
reviewed
Nov 23, 2023
blckngm
reviewed
Nov 23, 2023
blckngm
reviewed
Nov 23, 2023
driftluo
force-pushed
the
add-hash-for-trie-tree-keys
branch
2 times, most recently
from
November 24, 2023 01:59
cf215f0
to
5d3ec5b
Compare
driftluo
commented
Nov 24, 2023
blckngm
previously approved these changes
Nov 24, 2023
KaoImin
reviewed
Nov 27, 2023
driftluo
force-pushed
the
add-hash-for-trie-tree-keys
branch
from
November 27, 2023 02:17
5d3ec5b
to
df25f54
Compare
KaoImin
previously approved these changes
Nov 27, 2023
Flouse
reviewed
Nov 27, 2023
Co-authored-by: Flouse <[email protected]>
blckngm
approved these changes
Nov 27, 2023
Flouse
approved these changes
Nov 27, 2023
KaoImin
approved these changes
Nov 27, 2023
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 27, 2023
Flouse
changed the title
fix: add rlp encode for some key and value
BREAKING CHANGE: fix the implementation of Axon Tries
Nov 27, 2023
KaoImin
changed the title
BREAKING CHANGE: fix the implementation of Axon Tries
fix!: fix the implementation of Axon Tries
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR add rlp encode for some key and value:
eth_getProof
need to provide proof of non-existenceTest
now,there is a contract:
Deploy it, contract address is
0x5fc8d32690cc91d4c39d9d3abcbd707
, then query:Call method
setStorage
via transaction, sender address is0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
,then query:Calculate the position of pos1:
result:
0xa3c1274aadd82e4d12c8004c33fb244ca686dad4fcc8957fc5668588c11d9502
View the value of this location:
View the corresponding proof:
Test related code:
What is the impact of this PR?
Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
References
Footnotes
https://ethereum.org/en/developers/docs/data-structures-and-encoding/patricia-merkle-trie/#tries-in-ethereum ↩
https://ethereum.org/en/developers/docs/data-structures-and-encoding/patricia-merkle-trie/#storage-trie ↩