Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(executor)!: set_ckb_related_info transaction is not committed #1576

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix(executor)!: set_ckb_related_info transaction is not committed #1576

merged 2 commits into from
Nov 23, 2023

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Nov 20, 2023 •
edited
Loading

What this PR does / why we need it?

This PR will commit if function setCkbRelatedInfo of system contract Metadata is called.

What is the impact of this PR?

Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin changed the title bug: set_ckb_related_info not committed fix!: set_ckb_related_info transaction is not committed Nov 20, 2023
@KaoImin KaoImin changed the title fix!: set_ckb_related_info transaction is not committed fix(executor)!: set_ckb_related_info transaction is not committed Nov 20, 2023
@wenyuanhust wenyuanhust force-pushed the main branch 2 times, most recently from cb14069 to 8cea862 Compare November 20, 2023 08:03
@wenyuanhust wenyuanhust marked this pull request as ready for review November 20, 2023 08:06
@wenyuanhust wenyuanhust requested a review from a team as a code owner November 20, 2023 08:06
@Flouse Flouse requested review from ashuralyk, driftluo and KaoImin and removed request for Simon-Tl November 20, 2023 09:38
@wenyuanhust wenyuanhust force-pushed the main branch 2 times, most recently from a8f57c4 to 8260ace Compare November 21, 2023 01:12
@wenyuanhust wenyuanhust changed the title fix(executor)!: set_ckb_related_info transaction is not committed fix(executor)!: set_ckb_related_info transaction is not committed Nov 21, 2023
@Flouse Flouse requested a review from KaoImin November 21, 2023 07:19
@wenyuanhust wenyuanhust added this pull request to the merge queue Nov 23, 2023
Merged via the queue into axonweb3:main with commit 264a676 Nov 23, 2023
13 checks passed
@KaoImin KaoImin mentioned this pull request Nov 23, 2023
Closed
@Flouse Flouse linked an issue Nov 23, 2023 that may be closed by this pull request
Need method to fetch deployment info of metadata cell on CKB #1501
Closed
This was referenced Nov 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin approved these changes

@ashuralyk ashuralyk ashuralyk approved these changes

@blckngm blckngm Awaiting requested review from blckngm blckngm is a code owner automatically assigned from axonweb3/axon-dev

@driftluo driftluo Awaiting requested review from driftluo

Assignees

@wenyuanhust wenyuanhust

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need method to fetch deployment info of metadata cell on CKB
3 participants
@wenyuanhust @ashuralyk @KaoImin