Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typo in get_proof impl #1571

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: fix typo in get_proof impl #1571

merged 1 commit into from
Nov 17, 2023

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Nov 17, 2023

What this PR does / why we need it?

This PR fixes a typo in get_proof RPC impl where the storage proof is got from the state trie.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@blckngm blckngm requested a review from a team as a code owner November 17, 2023 04:30
@blckngm blckngm requested review from jjyr and Simon-Tl November 17, 2023 04:30
@Flouse Flouse requested review from driftluo and removed request for Simon-Tl November 17, 2023 04:32
@driftluo driftluo added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit d7e50cc Nov 17, 2023
21 checks passed
@KaoImin KaoImin deleted the fix-typo-get-proof branch November 17, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@KaoImin KaoImin KaoImin approved these changes

@jjyr jjyr Awaiting requested review from jjyr jjyr is a code owner automatically assigned from axonweb3/axon-dev

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blckngm @KaoImin @yangby-cryptape @driftluo