Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run unit tests in separate processes #1559

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

What this PR does / why we need it?

Since Axon uses global variables, run all tests in one process may cause unexpected errors.

With this PR, unit tests will run in separate processes, instead of in threads.

False errors in the unit tests decrease developers' expectation threshold, make developers feel that failed CI checks are reasonable.
Like the story of the boy who cried wolf, it's dangerous.

I have to check CI every time when I see a red cross mark ❌, false errors also increase my mental load.

Let false errors f**k off!

Out of Topic

The $HOME/.cargo/bin has more than 250 MiB binaries, which will be restored from cache, and then they will be overwritten by the binaries that download from internet.

Every workflow will put their tools that be downloaded into that directory, but no workflows will clean that directory.

Execute ls -l ~/.cargo/bin/`.
-rwxr-xr-x 1 runner docker 15474520 Oct 26 18:15 bindgen
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 cargo
-rwxr-xr-x 1 runner docker 28399320 Oct 26 18:15 cargo-audit
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 cargo-clippy
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 cargo-fmt
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 cargo-miri
-rwxr-xr-x 1 runner docker 16653376 Oct 26 18:15 cargo-outdated
-rwxr-xr-x 1 runner docker 12171496 Oct 26 18:15 cbindgen
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 clippy-driver
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rls
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rust-analyzer
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rust-gdb
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rust-gdbgui
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rust-lldb
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rustc
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rustdoc
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rustfmt
-rwxr-xr-x 1 runner docker 14293176 Oct 26 18:15 rustup

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@Flouse
Copy link
Contributor

Flouse commented Nov 15, 2023

Let false errors f**k off!

lol

@Flouse Flouse added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit c837c81 Nov 15, 2023
27 of 28 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/bugfix/ci-unit-tests-unexpected-errors branch November 18, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants