Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eth_getProof JSON RPC API #1540

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat: add eth_getProof JSON RPC API #1540

merged 1 commit into from
Nov 13, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Nov 10, 2023 •
edited by Flouse
Loading

What this PR does / why we need it?

This PR add eth_getProof API

close #1522

What is the impact of this PR?

No Breaking Change

Reference

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from a team as a code owner November 10, 2023 08:23
@KaoImin KaoImin changed the title feat: add get proof feat: add eth_getProof API Nov 10, 2023
@Flouse Flouse requested review from KaoImin, yangby-cryptape and blckngm and removed request for Simon-Tl November 10, 2023 08:30
KaoImin
KaoImin reviewed Nov 10, 2023
View reviewed changes
core/api/src/adapter.rs Show resolved Hide resolved
core/api/src/adapter.rs Outdated Show resolved Hide resolved
@KaoImin KaoImin changed the title feat: add eth_getProof API feat: add eth_getProof JSON RPC API Nov 10, 2023
blckngm
blckngm previously approved these changes Nov 10, 2023
View reviewed changes
@driftluo driftluo force-pushed the add-eth-get-proof branch 2 times, most recently from 71070fb to 086890c Compare November 10, 2023 09:13
Flouse
Flouse reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the API docs.

@Flouse Flouse mentioned this pull request Nov 13, 2023
Closed
@Flouse Flouse enabled auto-merge November 13, 2023 05:31
@Flouse Flouse added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit e310f38 Nov 13, 2023
23 checks passed
@driftluo driftluo deleted the add-eth-get-proof branch November 13, 2023 06:03
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
@driftluo @KaoImin
feat: add eth_getProof JSON RPC API (#1540)
dbf2a5f 
feat: add get proof
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin approved these changes

@Flouse Flouse Flouse approved these changes

@blckngm blckngm blckngm left review comments

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust wenyuanhust is a code owner automatically assigned from axonweb3/axon-dev

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
t:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support eth_getProof(EIP-1186)
4 participants
@driftluo @Flouse @blckngm @KaoImin