Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move axon-tools to axon #1519

Merged
merged 3 commits into from
Nov 2, 2023
Merged

feat: move axon-tools to axon #1519

merged 3 commits into from
Nov 2, 2023

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Nov 1, 2023 •
edited
Loading

What this PR does / why we need it?

This PR

  • moves the std part of axon-tools into the devtools/axon-tools of axon.
  • add tests for block verify and tx verify.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@wenyuanhust wenyuanhust requested a review from a team as a code owner November 1, 2023 06:32
@wenyuanhust wenyuanhust force-pushed the main branch 2 times, most recently from 9bd2f4c to c783383 Compare November 1, 2023 07:37
@wenyuanhust wenyuanhust requested a review from KaoImin November 1, 2023 08:25
KaoImin
KaoImin reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@KaoImin KaoImin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rlp Encodable and Decodable implement code should be abstract into a standalonerlp_codec.rs file.

devtools/axon-tools/src/types.rs Outdated Show resolved Hide resolved
@Flouse Flouse requested review from driftluo and yangby-cryptape and removed request for jjyr November 1, 2023 13:52
@wenyuanhust wenyuanhust force-pushed the main branch 2 times, most recently from a35228a to 7573d4d Compare November 2, 2023 01:23
KaoImin
KaoImin previously approved these changes Nov 2, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

@Flouse Flouse requested review from ashuralyk and removed request for sunchengzhu November 2, 2023 05:54
@wenyuanhust wenyuanhust added this pull request to the merge queue Nov 2, 2023
Merged via the queue into axonweb3:main with commit 68aa8a9 Nov 2, 2023
12 checks passed
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
@wenyuanhust @KaoImin
feat: move axon-tools to axon (#1519)
109b42b 
* feat: move axon-tools to axon

* refactor: improve code organization

* test: add axon-tools unit test
@yangby-cryptape yangby-cryptape mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin approved these changes

@ashuralyk ashuralyk ashuralyk approved these changes

@driftluo driftluo Awaiting requested review from driftluo

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees

@wenyuanhust wenyuanhust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenyuanhust @ashuralyk @KaoImin