fix: fix evm config init #1484

driftluo · 2023-10-17T05:39:26Z

What this PR does / why we need it?

This PR fixes evm config init with hardfork features

What is the impact of this PR?

No Breaking Change

PR relation:

Ref #

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

CI Description

CI Name	Description
Web3 Compatible Test	Test the Web3 compatibility of Axon
v3 Core Test	Run the compatibility tests provided by Uniswap V3
OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19	Run the compatibility tests provided by OpenZeppelin

sunchengzhu · 2023-10-17T15:41:09Z

This commit (371579d) fixed the issue where max_contract_limit was not taking effect when starting the axon node with hardforks = []. However, the problem still persists when starting with hardforks = ["None"]. Please check. @driftluo

sunchengzhu · 2023-10-18T06:20:18Z

This commit (17c7a66) has been successfully verified locally. @driftluo @KaoImin
Regardless of starting the Axon node with the configuration hardforks = [] or hardforks = ["None"], attempting to deploy a contract that exceeds the max_contract_limit size will result in the following error:

jsonRpcResponse: {
  jsonrpc: '2.0',
  error: {
    code: -49998,
    message: 'CKB-VM error execution reverted: ',
    data: 'CreateContractLimit'
  },
  id: 2
}

yangby-cryptape · 2023-10-18T06:27:27Z

jsonRpcResponse: {
  jsonrpc: '2.0',
  error: {
    code: -49998,
    message: 'CKB-VM error execution reverted: ',
    data: 'CreateContractLimit'
  },
  id: 2
}

Has nothing to do with the current PR.
Not issue of current PR, it's an already existed issue.

I have already point that in #1457 but be ingored: Why the error message is related to CKB-VM?
I tried some other EVM contracts which must be failed, and they could got the same messages sometimes.

driftluo · 2023-10-18T06:34:36Z

I have already point that in #1457 but be ingored: Why the error message is related to CKB-VM? I tried some other EVM contracts which must be failed, and they could got the same messages sometimes.

https://github.com/axonweb3/axon/blob/main/core/api/src/jsonrpc/error.rs#L57
It should be a display problem, this is the display setting returned by rpc

KaoImin · 2023-10-18T09:10:51Z

I have already point that in #1457 but be ingored: Why the error message is related to CKB-VM? I tried some other EVM contracts which must be failed, and they could got the same messages sometimes.

main/core/api/src/jsonrpc/error.rs#L57 It should be a display problem, this is the display setting returned by rpc

axon/core/api/src/jsonrpc/error.rs

Lines 57 to 58 in a2d8e04

    
           #[display(fmt = "CKB-VM error {}", "decode_revert_msg(&_0.ret)")] 
        
           VM(TxResp),

The error display should be changed as following:

    #[display(fmt = "EVM error {}", "decode_revert_msg(&_0.ret)")] 
    EVM(TxResp),

core/api/src/jsonrpc/error.rs

github-actions · 2023-10-18T09:21:30Z

CI tests run on commit:

commit id: 5ba15fe

CI test list:

Web3 Compatible Tests

Please check ci test results later.

github-actions · 2023-10-18T10:00:21Z

CI tests run on commit:

commit id: fe64e40

CI test list:

Web3 Compatible Tests

Please check ci test results later.

github-actions · 2023-10-18T10:17:00Z

CI tests run on commit:

commit id: fe64e40

CI test list:

Web3 Compatible Tests

Please check ci test results later.

sunchengzhu · 2023-10-18T11:40:23Z

The error message returned by commit (fe64e40) is as follows:

jsonRpcResponse: {
  jsonrpc: '2.0',
  error: {
    code: -49998,
    message: 'EVM error execution reverted: ',
    data: 'CreateContractLimit'
  },
  id: 2
}

Flouse · 2023-10-18T12:01:41Z

core/executor/src/lib.rs

            if latest_hardfork_info & &enable_contract_limit_flag == enable_contract_limit_flag {
                let handle = MetadataHandle::new(CURRENT_METADATA_ROOT.with(|r| *r.borrow()));
                let config = handle.get_consensus_config().unwrap();
                Some(config.max_contract_limit as usize)
            } else {
-                None
+                Some(0x6000)


Is it better to use fn default_max_contract_limit instead of hardcoding 0x6000?

driftluo requested a review from KaoImin October 17, 2023 05:39

driftluo requested a review from a team as a code owner October 17, 2023 05:39

driftluo requested a review from blckngm October 17, 2023 05:39

github-actions bot added the bugfix label Oct 17, 2023

KaoImin previously approved these changes Oct 17, 2023

View reviewed changes

Flouse requested review from sunchengzhu and yangby-cryptape October 17, 2023 11:49

driftluo dismissed KaoImin’s stale review via 17c7a66 October 18, 2023 02:12

driftluo force-pushed the fix-evm-config branch from 371579d to 17c7a66 Compare October 18, 2023 02:12

sunchengzhu previously approved these changes Oct 18, 2023

View reviewed changes

driftluo dismissed sunchengzhu’s stale review via 3e0fffb October 18, 2023 09:16

driftluo force-pushed the fix-evm-config branch from 17c7a66 to 3e0fffb Compare October 18, 2023 09:16

KaoImin reviewed Oct 18, 2023

View reviewed changes

core/api/src/jsonrpc/error.rs Outdated Show resolved Hide resolved

driftluo force-pushed the fix-evm-config branch from 3e0fffb to 5ba15fe Compare October 18, 2023 09:20

KaoImin previously approved these changes Oct 18, 2023

View reviewed changes

This comment was marked as off-topic.

Sign in to view

fix: fix evm config init

fe64e40

driftluo dismissed KaoImin’s stale review via fe64e40 October 18, 2023 09:25

driftluo force-pushed the fix-evm-config branch from 5ba15fe to fe64e40 Compare October 18, 2023 09:25

KaoImin approved these changes Oct 18, 2023

View reviewed changes

This comment was marked as abuse.

Sign in to view

This comment was marked as off-topic.

Sign in to view

KaoImin enabled auto-merge October 18, 2023 10:49

KaoImin requested a review from sunchengzhu October 18, 2023 10:55

sunchengzhu approved these changes Oct 18, 2023

View reviewed changes

KaoImin added this pull request to the merge queue Oct 18, 2023

Merged via the queue into main with commit 0ee928d Oct 18, 2023
17 checks passed

driftluo deleted the fix-evm-config branch October 18, 2023 11:50

Flouse reviewed Oct 18, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix evm config init #1484

fix: fix evm config init #1484

driftluo commented Oct 17, 2023 •

edited by KaoImin

Loading

sunchengzhu commented Oct 17, 2023 •

edited

Loading

sunchengzhu commented Oct 18, 2023 •

edited

Loading

yangby-cryptape commented Oct 18, 2023 •

edited

Loading

driftluo commented Oct 18, 2023

KaoImin commented Oct 18, 2023

This comment was marked as off-topic.

github-actions bot commented Oct 18, 2023

This comment was marked as abuse.

github-actions bot commented Oct 18, 2023

This comment was marked as off-topic.

github-actions bot commented Oct 18, 2023

sunchengzhu commented Oct 18, 2023

Flouse Oct 18, 2023

fix: fix evm config init #1484

fix: fix evm config init #1484

Conversation

driftluo commented Oct 17, 2023 • edited by KaoImin Loading

What this PR does / why we need it?

What is the impact of this PR?

CI Usage

CI Description

sunchengzhu commented Oct 17, 2023 • edited Loading

sunchengzhu commented Oct 18, 2023 • edited Loading

yangby-cryptape commented Oct 18, 2023 • edited Loading

driftluo commented Oct 18, 2023

KaoImin commented Oct 18, 2023

This comment was marked as off-topic.

github-actions bot commented Oct 18, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

This comment was marked as abuse.

github-actions bot commented Oct 18, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

This comment was marked as off-topic.

github-actions bot commented Oct 18, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

sunchengzhu commented Oct 18, 2023

Flouse Oct 18, 2023

Choose a reason for hiding this comment

driftluo commented Oct 17, 2023 •

edited by KaoImin

Loading

sunchengzhu commented Oct 17, 2023 •

edited

Loading

sunchengzhu commented Oct 18, 2023 •

edited

Loading

yangby-cryptape commented Oct 18, 2023 •

edited

Loading