Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix get metadata by number #1483

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: fix get metadata by number #1483

merged 1 commit into from
Oct 18, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Oct 17, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it?

This PR fix get metadata by number

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo marked this pull request as ready for review October 17, 2023 03:35
@driftluo driftluo requested a review from a team as a code owner October 17, 2023 03:35
@driftluo driftluo requested review from jjyr, Simon-Tl and KaoImin and removed request for jjyr and Simon-Tl October 17, 2023 03:35
@sunchengzhu
Copy link
Collaborator

The local verification of this feature passed.

@KaoImin
Copy link
Contributor

KaoImin commented Oct 18, 2023

/run-ci

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Oct 18, 2023
@KaoImin KaoImin removed this pull request from the merge queue due to a manual request Oct 18, 2023
@KaoImin KaoImin added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit a2d8e04 Oct 18, 2023
22 of 23 checks passed
@driftluo driftluo deleted the fix-get-metadata-by-number branch October 18, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunchengzhu sunchengzhu sunchengzhu approved these changes

@KaoImin KaoImin KaoImin approved these changes

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftluo @sunchengzhu @KaoImin