Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: no plain-text private key in configuration file #1481

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Oct 16, 2023

What this PR does / why we need it?

Resolve the issue which was originally in #1471 (comment).

The files devtools/chain/k8s/sync_nodes/node_[567].toml were broken since #1471.
After confirming with @KaoImin, these files will be removed in this PR.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review October 16, 2023 08:39
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner October 16, 2023 08:39
@yangby-cryptape yangby-cryptape requested review from jjyr, Simon-Tl, Flouse, driftluo and KaoImin and removed request for jjyr and Simon-Tl October 16, 2023 08:39
@Flouse Flouse added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit ad39af9 Oct 20, 2023
19 of 20 checks passed
@KaoImin KaoImin deleted the yangby/refactor/disable-plain-secrets branch October 23, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants