Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set CORS to any to accept RPC calls from web-based apps #1459

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

What this PR does / why we need it?

This PR fixes #1456.

How

Since Axon is a Layer 2 framework, it should focus on blockchain features.
So I just set CROS to be "*".

If users want more security features, they should use a professional proxy server, such as Nginx, ahead Axon.

Why

Axon couldn't be a professional server, even Axon support configuration of CROS, users still need a professional proxy server for production environments.

Leave professional things to professionals.

References

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape marked this pull request as ready for review September 29, 2023 16:06
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner September 29, 2023 16:06
@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape removed the request for review from wenyuanhust September 29, 2023 16:26
@Flouse Flouse requested review from blckngm and KaoImin September 30, 2023 03:22
@KaoImin KaoImin added this pull request to the merge queue Oct 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2023
@Flouse Flouse added this pull request to the merge queue Oct 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2023
@Flouse Flouse merged commit d8ac76d into main Oct 1, 2023
17 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/fix/set-cors-be-any branch October 4, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MetaMask] Failed to add network following the official docs.
3 participants