-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: insert metadata directly and remove genesis transactions #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
requested review from
Flouse and
yangby-cryptape
and removed request for
ashuralyk
September 27, 2023 07:28
6 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
4 tasks
Flouse
reviewed
Oct 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the following code is useless, right?
Lines 130 to 147 in f000c0f
for (i, (block_cached, tx)) in genesis | |
.block | |
.tx_hashes | |
.iter() | |
.zip(genesis.txs.iter()) | |
.enumerate() | |
{ | |
let tx_cached = tx.transaction.hash; | |
assert_eq!( | |
*block_cached, tx_cached, | |
"check hash of tx[{i}], in-block: {block_cached:#x}, tx-cached: {tx_cached:#x}", | |
); | |
let calculated = tx.transaction.clone().calc_hash().hash; | |
assert_eq!( | |
tx_cached, calculated, | |
"check hash of tx[{i}], cached: {tx_cached:#x}, calculated: {calculated:#x}", | |
); | |
} |
Flouse
reviewed
Oct 1, 2023
KaoImin
force-pushed
the
remove-genesis-transaction
branch
from
October 7, 2023 01:56
f000c0f
to
1df6ee1
Compare
Yes |
KaoImin
force-pushed
the
remove-genesis-transaction
branch
from
October 8, 2023 13:14
94f68f6
to
dacb972
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
force-pushed
the
remove-genesis-transaction
branch
from
October 9, 2023 04:14
dacb972
to
7d73ca2
Compare
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
reviewed
Oct 9, 2023
driftluo
approved these changes
Oct 9, 2023
yangby-cryptape
approved these changes
Oct 9, 2023
4 tasks
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR removes the generation of genesis transactions. The first two metadata and the consensus config are inserted to DB directly.
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description