Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: initialize chain without user-provided genesis transactions file #1450

Merged
merged 1 commit into from
Sep 26, 2023
Merged

refactor: initialize chain without user-provided genesis transactions file #1450

merged 1 commit into from
Sep 26, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 26, 2023 •
edited
Loading

What this PR does / why we need it?

Initialize chain without user-provided genesis transactions file.

The data in the transaction file will be re-written, so this file is useless, it could be removed.

ℹ️ This change doesn't change the preset hashes in unit tests.

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape requested a review from a team as a code owner September 26, 2023 04:32
@Flouse Flouse requested a review from KaoImin September 26, 2023 06:40
@Flouse Flouse linked an issue Sep 26, 2023 that may be closed by this pull request
The genesis transactions are opaque with poor readability #1408
Closed
@KaoImin
Copy link
Contributor

KaoImin commented Sep 26, 2023

/run-ci

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@Flouse Flouse mentioned this pull request Sep 26, 2023
Closed
@Flouse Flouse added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@yangby-cryptape yangby-cryptape added this pull request to the merge queue Sep 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2023
@Flouse Flouse added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 47e7407 Sep 26, 2023
20 checks passed
@Flouse Flouse linked an issue Sep 26, 2023 that may be closed by this pull request
Transactions root of genesis block is incorrect #1305
Closed
20 tasks
@KaoImin KaoImin deleted the yangby/refactor/init-chain-without-transactions branch October 12, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin KaoImin approved these changes

@Flouse Flouse Flouse approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The genesis transactions are opaque with poor readability Transactions root of genesis block is incorrect
3 participants
@yangby-cryptape @KaoImin @Flouse