Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove first genesis transaction #1443

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 21, 2023

What this PR does / why we need it?

This PR remove the first genesis transaction.

The final goal is to remove the private key which is used to initialize a chain.

The owner of that private key is the admin of the contract in the first genesis transaction.
That makes the chain to be centralized.

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as off-topic.

@Flouse Flouse requested a review from KaoImin September 21, 2023 08:58
@Flouse Flouse linked an issue Sep 21, 2023 that may be closed by this pull request
@yangby-cryptape yangby-cryptape force-pushed the yangby/refactor/remove-first-genesis-transaction branch from 5c03d98 to f209af8 Compare September 22, 2023 08:38
@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as off-topic.

@yangby-cryptape yangby-cryptape force-pushed the yangby/refactor/remove-first-genesis-transaction branch from f209af8 to a3ecd57 Compare September 22, 2023 12:27
@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review September 22, 2023 13:27
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner September 22, 2023 13:27
Flouse

This comment was marked as resolved.

@yangby-cryptape yangby-cryptape force-pushed the yangby/refactor/remove-first-genesis-transaction branch from a3ecd57 to 87c73ae Compare September 22, 2023 14:43
@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 83ea6f2 Sep 25, 2023
19 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/refactor/remove-first-genesis-transaction branch September 25, 2023 08:21
@Flouse Flouse linked an issue Sep 26, 2023 that may be closed by this pull request
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The genesis transactions are opaque with poor readability Transactions root of genesis block is incorrect
3 participants