-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove first genesis transaction #1443
Merged
KaoImin
merged 1 commit into
main
from
yangby/refactor/remove-first-genesis-transaction
Sep 25, 2023
Merged
refactor: remove first genesis transaction #1443
KaoImin
merged 1 commit into
main
from
yangby/refactor/remove-first-genesis-transaction
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
yangby-cryptape
force-pushed
the
yangby/refactor/remove-first-genesis-transaction
branch
from
September 22, 2023 08:38
5c03d98
to
f209af8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
yangby-cryptape
force-pushed
the
yangby/refactor/remove-first-genesis-transaction
branch
from
September 22, 2023 12:27
f209af8
to
a3ecd57
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
force-pushed
the
yangby/refactor/remove-first-genesis-transaction
branch
from
September 22, 2023 14:43
a3ecd57
to
87c73ae
Compare
Flouse
approved these changes
Sep 22, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Sep 25, 2023
yangby-cryptape
deleted the
yangby/refactor/remove-first-genesis-transaction
branch
September 25, 2023 08:21
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR remove the first genesis transaction.
The final goal is to remove the private key which is used to initialize a chain.
The owner of that private key is the admin of the contract in the first genesis transaction.
That makes the chain to be centralized.
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc