-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hardfork storage to metadata contract #1380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
requested review from
KaoImin
and removed request for
Simon-Tl and
felicityin
August 29, 2023 06:08
KaoImin
reviewed
Aug 29, 2023
KaoImin
reviewed
Aug 29, 2023
KaoImin
reviewed
Aug 29, 2023
KaoImin
reviewed
Aug 29, 2023
KaoImin
reviewed
Aug 29, 2023
The |
KaoImin
changed the title
feat: hardfork storage
feat: add hardfork storage to metadata contract
Aug 29, 2023
driftluo
force-pushed
the
hardfork-storage
branch
2 times, most recently
from
August 29, 2023 09:48
c90e94a
to
e110185
Compare
KaoImin
reviewed
Aug 29, 2023
driftluo
force-pushed
the
hardfork-storage
branch
2 times, most recently
from
August 30, 2023 03:40
827c369
to
a76493a
Compare
KaoImin
reviewed
Aug 30, 2023
driftluo
force-pushed
the
hardfork-storage
branch
from
August 30, 2023 07:08
a76493a
to
8948fb4
Compare
KaoImin
previously approved these changes
Aug 30, 2023
driftluo
force-pushed
the
hardfork-storage
branch
from
August 31, 2023 03:47
8948fb4
to
88cc50d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
KaoImin
previously approved these changes
Aug 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
driftluo
force-pushed
the
hardfork-storage
branch
from
August 31, 2023 06:44
88cc50d
to
56ecdf3
Compare
driftluo
force-pushed
the
hardfork-storage
branch
from
August 31, 2023 06:46
56ecdf3
to
96cb9d7
Compare
yangby-cryptape
approved these changes
Aug 31, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR implemented storage-related functionality in hardfork:
All hardfork-related functionality must be updated at every block generation.
Restart, activation, and startup status settings will be improved in subsequent PRs
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc