Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hardfork storage to metadata contract #1380

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Aug 29, 2023

What this PR does / why we need it?

This PR implemented storage-related functionality in hardfork:

  • HARDFORK_KEY to stores all planned or achieved hardfork times
  • HARDFORK_INFO caches current hardfork flags
  • flags will be H256, Any hardfork will be represented by an independent and non-repeating bit

All hardfork-related functionality must be updated at every block generation.

Restart, activation, and startup status settings will be improved in subsequent PRs

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Code Format
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from a team as a code owner August 29, 2023 06:07
@driftluo driftluo requested review from KaoImin and removed request for Simon-Tl and felicityin August 29, 2023 06:08
@KaoImin
Copy link
Contributor

KaoImin commented Aug 29, 2023

The ABI of metadata contract does not need to be changed.

@KaoImin KaoImin changed the title feat: hardfork storage feat: add hardfork storage to metadata contract Aug 29, 2023
@driftluo driftluo force-pushed the hardfork-storage branch 2 times, most recently from c90e94a to e110185 Compare August 29, 2023 09:48
@driftluo driftluo force-pushed the hardfork-storage branch 2 times, most recently from 827c369 to a76493a Compare August 30, 2023 03:40
KaoImin
KaoImin previously approved these changes Aug 30, 2023
@KaoImin

This comment was marked as off-topic.

KaoImin
KaoImin previously approved these changes Aug 31, 2023
@github-actions

This comment was marked as outdated.

@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • E2E Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit b0af286 Aug 31, 2023
31 checks passed
@driftluo driftluo deleted the hardfork-storage branch August 31, 2023 08:29
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants