fix: use a same trie for the same chain #1370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Currently, during axon starting, there will be 4
RocksTrieDB
instances are used.This PR only reduce the number of instances from 4 to 1.
Description
Each time to create a new instance of
RocksTrieDB
, a newcache
will be created:axon/core/executor/src/adapter/trie/db.rs
Lines 148 to 150 in fc199ba
axon/core/executor/src/adapter/trie/db.rs
Lines 29 to 34 in fc199ba
Different
cache
for different instances, then theRwLock
can do nothing for consistency.What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc