-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: slightly improve security for secret keys #1367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
Flouse,
driftluo and
KaoImin
and removed request for
ahonn and
felicityin
August 25, 2023 17:31
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
reviewed
Aug 26, 2023
KaoImin
reviewed
Aug 26, 2023
yangby-cryptape
force-pushed
the
yangby/refactor/secrets-security
branch
from
August 27, 2023 03:54
3ac91cf
to
68f92ba
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
9 tasks
yangby-cryptape
force-pushed
the
yangby/refactor/secrets-security
branch
from
August 28, 2023 08:04
68f92ba
to
7ed58f3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Flouse
previously approved these changes
Aug 28, 2023
9 tasks
yangby-cryptape
force-pushed
the
yangby/refactor/secrets-security
branch
from
August 28, 2023 09:12
19de48a
to
09a12ae
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Aug 28, 2023
KaoImin
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Keep a human-readable string of a private key is very dangerous.
Do not copy private keys again and again.
If the memory of a private key is not zeroized after the key dropped, it could be read from other threads and other processes.
Also, that piece of memory could be read by programs started after axon stopped.
Remove unnecessary
unwrap()
and structs conversions.What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc