-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: impl Trie
for MPTTrie
#1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
Flouse,
driftluo and
KaoImin
and removed request for
blckngm and
wenyuanhust
August 25, 2023 09:38
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
force-pushed
the
yangby/refactor/impl-trie-for-mpttrie
branch
from
August 25, 2023 18:28
61b3bcf
to
5172b95
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
previously approved these changes
Aug 26, 2023
The pub type MPTTrie<DB: trie::DB> = trie::PatriciaTrie<DB, HasherKeccak>; |
I only remove the class methods which are conflict with trait methods of |
yangby-cryptape
force-pushed
the
yangby/refactor/impl-trie-for-mpttrie
branch
from
August 29, 2023 06:07
5172b95
to
e0d87c9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
previously approved these changes
Aug 29, 2023
yangby-cryptape
force-pushed
the
yangby/refactor/impl-trie-for-mpttrie
branch
from
August 29, 2023 06:23
e0d87c9
to
fcf15ad
Compare
KaoImin
approved these changes
Aug 29, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
I want to add methods to
MPTTrie<DB>
in another crate.Limit by the orphan rule, I have to use a trait to add methods to
MPTTrie<DB>
.If I use a trait to add methods to
MPTTrie<DB>
, I could NOT write the following code:, since
MPTTrie<DB>
is a struct, but I can write the following code:Some methods of
MPTTrie<DB>
are not exposed, for example,get_proof(..)
andverify_proof(..)
.Another reason:
In fact,
MPTTrie<DB>
is aTrie
, we should use it asTrie
directly.Trie
is in a higher level ofTrieDB
in abstract.Treat
MPTTrie<DB>
as as aTrieDB
is not reasonable.What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc