Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless test for sol contract #1355

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Aug 24, 2023

What this PR does / why we need it?

This PR remove the useless test for metadata sol contract and make metadata sol contract consistent with the abi implemented by rust

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from a team as a code owner August 24, 2023 02:55
@driftluo driftluo requested review from jjyr and felicityin August 24, 2023 02:55
@driftluo driftluo requested review from Flouse, KaoImin and yangby-cryptape and removed request for jjyr and felicityin August 24, 2023 02:55
@yangby-cryptape
Copy link
Collaborator

So, no new unit tests added for recently changes, but remove some.

After all development for hardfork feature, is there a plan to add some unit tests?

@driftluo
Copy link
Contributor Author

After all development for hardfork feature, is there a plan to add some unit tests?

I added a test of update consensus config in this commit

@KaoImin
Copy link
Contributor

KaoImin commented Aug 24, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Aug 24, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Unit Tests

Please check ci test results later.

@KaoImin KaoImin mentioned this pull request Aug 24, 2023
9 tasks
@KaoImin KaoImin added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 8ff7658 Aug 24, 2023
@driftluo driftluo deleted the remove-useless-test branch August 24, 2023 05:23
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
* refactor: remove useless test for sol contract

* test: add test for update consensus config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants