Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prometheus could not be disabled #1348

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Aug 22, 2023

What this PR does / why we need it?

This PR fixes:

  • The server of prometheus could not be disabled.
  • High security risk since the default address of prometheus is unspecified address.
  • Should not use unwrap() since the address could be not provided.
  • Cause errors for CI checks of multi-nodes. (ref: an example).
    • The configuration files for the multi-nodes test in CI haven't set prometheus section.
      So, all nodes use the default address. Then an error is caused: "Address already in use (os error 98)".

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape requested a review from a team as a code owner August 22, 2023 13:56
@yangby-cryptape yangby-cryptape requested review from jjyr, ashuralyk, Flouse, driftluo and KaoImin and removed request for jjyr and ashuralyk August 22, 2023 13:56
@Flouse Flouse added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 0ed2ce6 Aug 22, 2023
@Flouse Flouse deleted the yangby/bugfix/prometheus-could-not-be-disabled branch August 22, 2023 16:00
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants