-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove useless fields in BlockHeader
#1339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
requested review from
jjyr,
ashuralyk,
Flouse,
driftluo and
yangby-cryptape
and removed request for
jjyr and
ashuralyk
August 20, 2023 16:31
KaoImin
changed the title
refactor: remove useless fields in
refactor!: remove useless fields in Aug 20, 2023
lockHeader
lockHeader
KaoImin
changed the title
refactor!: remove useless fields in
refactor!: remove useless fields in Aug 20, 2023
lockHeader
BlockHeader
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
driftluo
previously approved these changes
Aug 21, 2023
KaoImin
force-pushed
the
refactor-header
branch
from
August 21, 2023 03:12
fb33a0f
to
6e65306
Compare
yangby-cryptape
previously approved these changes
Aug 21, 2023
driftluo
previously approved these changes
Aug 21, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
previously approved these changes
Aug 22, 2023
driftluo
previously approved these changes
Aug 22, 2023
Flouse
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to update the test data?
Lines 12 to 19 in db0c608
"difficulty": "0x0", | |
"timestamp": 1679656015, | |
"number": 0, | |
"gas_used": "0x0", | |
"gas_limit": "0x0", | |
"extra_data": [], | |
"mixed_hash": null, | |
"nonce": "0x0000000000000000", |
KaoImin
force-pushed
the
refactor-header
branch
from
August 22, 2023 02:41
23443c7
to
f4d51d1
Compare
KaoImin
force-pushed
the
refactor-header
branch
from
August 22, 2023 02:46
f4d51d1
to
fbb4370
Compare
Flouse
approved these changes
Aug 22, 2023
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
driftluo
approved these changes
Aug 22, 2023
yangby-cryptape
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR remove these three fields in
Header
:difficulty
nonce
mixed_hash
They are all mining related and useless to Axon. The rpc will return the default value.
What is the impact of this PR?
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc