-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: read-write separation and merge rocksdb instance #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoImin
changed the title
chore: upgrade some crates
refactor: read-write separation and merge rocksdb instance
Aug 18, 2023
KaoImin
requested review from
blckngm and
driftluo
and removed request for
ashuralyk
August 18, 2023 15:30
KaoImin
changed the title
refactor: read-write separation and merge rocksdb instance
refactor!: read-write separation and merge rocksdb instance
Aug 18, 2023
KaoImin
force-pushed
the
refactor-db
branch
3 times, most recently
from
August 20, 2023 16:20
084580c
to
abbb23d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
force-pushed
the
refactor-db
branch
2 times, most recently
from
August 21, 2023 10:41
6d8fd32
to
c6e57ce
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
previously approved these changes
Aug 22, 2023
driftluo
previously approved these changes
Aug 22, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
yangby-cryptape
approved these changes
Aug 22, 2023
driftluo
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR contains two part:
The part 1 is the precondition of part 2.
Read-write separation
Storage
trait intoReadOnlyStorage
andStorage
. TheReadOnlyStorage
contains all theget*
methods and theStorage
trait inherit theReadOnlyStorage
trait.ExecutorAdaptor
trait intoReadOnlyExecutorAdaptor
andExecutorAdaptor
. The difference is that theExecutorAdaptor
requires theApplyBackend
trait.consensus
module and executor module useStorage
andAPI
module andmempool
module useReadOnlyStorage
consensus
module useExecutorAdaptor
andAPI
module,interoperation
module andmempool
module useReadOnlyExecutorAdaptor
Merge RocksDB instance
This PR abstracts the adapter module in the
core/storage
crate into a new standalone crate namedcore/db
. The new crate contains memory DB and RocksDB wrapper functionalities. Bothcore/storage
andcore/executor
now directly depend oncore/db
, which is a change from the previous setup. The formerstate_db
,metadata_db
, andheader_cell_db
are now represented asc8
,c9
, andc10
column families within the main RocksDB instance. This restructuring enhances modularity and efficiency in managing database components.What is the impact of this PR?
The previous data folder layout:
The current data folder layout:
Special notes for your reviewer
Because of this PR change so many files, review it commit by commit.
Which issue(s) this PR fixes:
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch